This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Introducing FlytePropeller TURBO Mode #minor #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turbo mode in FlytePropeller
EngHabu
previously approved these changes
Jan 31, 2021
pkg/controller/config/config.go
Outdated
| @@ -74,6 +74,7 @@ type Config struct { | |||
| MaxDatasetSizeBytes int64 `json:"max-output-size-bytes" pflag:",Maximum size of outputs per task"` | |||
| KubeConfig KubeClientConfig `json:"kube-client-config" pflag:",Configuration to control the Kubernetes client"` | |||
| NodeConfig NodeConfig `json:"node-config,omitempty" pflag:",config for a workflow node"` | |||
| EnableFastFollow bool `json:"enable-fast-follow" pflag:",Boolean flag that enables Fast Follow mode, this makes Propeller proceed to another round on successful write to etcD."` | |||
There was a problem hiding this comment.
nit: formatting seems to have more spaces... tabs?
There was a problem hiding this comment.
will fix formatting
kumare3
changed the title
kumare3
changed the title
EngHabu
reviewed
Feb 1, 2021
pkg/controller/config/config.go
Outdated
| @@ -74,6 +76,8 @@ type Config struct { | |||
| MaxDatasetSizeBytes int64 `json:"max-output-size-bytes" pflag:",Maximum size of outputs per task"` | |||
| KubeConfig KubeClientConfig `json:"kube-client-config" pflag:",Configuration to control the Kubernetes client"` | |||
| NodeConfig NodeConfig `json:"node-config,omitempty" pflag:",config for a workflow node"` | |||
| EnableTurboMode bool `json:"enable-turbo-mode" pflag:",Boolean flag that enables Turbo-mode, this makes Propeller proceed to another round on successful write to etcD."` | |||
There was a problem hiding this comment.
Should we really have two flags? or just have it enabled all the time and use MaxStreakLength <= 1 meaning it essentially has no effect?
EngHabu
reviewed
Feb 3, 2021
EngHabu
approved these changes
Feb 4, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR adds a new configuration to FlytePropeller which is enabled by default. This improves the transition latency of FlytePropeller by an order of magnitude or more. Absolute comparison to come soon.
Type
Are all requirements met?
Complete description
Currently FlytePropeller event loop is designed to make the smallest forward progress in each round. There are cases in which the round progress is purely book-keeping. For example moving a workflow from accepted to Running state. Moving a node from new to queued to running state. This is done so that state is resilient from crashes.
the turbo mode, essentially waits for the one of these rounds to complete and optimistically progresses to the next round using the updated state. To add safety to the optimistic progress we can configure bounds.
The psuedo algorithm
Tracking Issue
flyteorg/flyte#676